Use ShareCompat.IntentBuilder for sharing content#4745
Merged
bmarty merged 3 commits intoelement-hq:developfrom Jan 3, 2022
Merged
Use ShareCompat.IntentBuilder for sharing content#4745bmarty merged 3 commits intoelement-hq:developfrom
bmarty merged 3 commits intoelement-hq:developfrom
Conversation
bmarty
reviewed
Dec 30, 2021
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
Thanks for the PR!
Can you add a file for the changelog and a sign-off please? You'll find more information about that in https://github.com/vector-im/element-android/blob/develop/CONTRIBUTING.md
vector/src/main/java/im/vector/app/core/utils/ExternalApplicationsUtil.kt
Outdated
Show resolved
Hide resolved
vector/src/main/java/im/vector/app/core/utils/ExternalApplicationsUtil.kt
Outdated
Show resolved
Hide resolved
Signed-off-by: Tobias Preuss <tobias.preuss@googlemail.com>
Signed-off-by: Tobias Preuss <tobias.preuss@googlemail.com>
…ontent. + Although the system's intent chooser normally takes care of cases when no app is found we still keep the safeguard here to be prepared for exotic devices behaving different. Signed-off-by: Tobias Preuss <tobias.preuss@googlemail.com>
johnjohndoe
force-pushed
the
sharecompat
branch
from
fbd0421 to
74363ff
Compare
bmarty
approved these changes
Jan 3, 2022
Member
bmarty
left a comment
bmarty
left a comment
There was a problem hiding this comment.
LGTM, I will rename createChooser to safeStartActivity which is more appropriate I think
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ShareCompat.IntentBuilderAPI.Pull Request Checklist
or videos if containing UI changesScreenshots